Repository navigation
Conversation
fwiesel
force-pushed
the
fix-786-stale-service-id
branch
from
October 30, 2026 17:20
b2f3e90 to
e1655f4
Compare
fwiesel
force-pushed
the
fix-786-stale-service-id
branch
11 times, most recently
from
November 16, 2026 09:29
cd0b3b9 to
1013379
Compare
fwiesel
force-pushed
the
fix-786-stale-service-id
branch
from
November 16, 2026 09:49
1013379 to
6af0982
Compare
fwiesel
force-pushed
the
fix-786-stale-service-id
branch
2 times, most recently
from
November 16, 2026 10:19
e71ec0c to
4658af8
Compare
fwiesel
force-pushed
the
fix-786-stale-service-id
branch
8 times, most recently
from
November 16, 2026 11:51
3ea3cb8 to
2153a33
Compare
fwiesel
force-pushed
the
fix-786-stale-service-id
branch
from
November 16, 2026 12:00
2153a33 to
4862faf
Compare
fwiesel
force-pushed
the
fix-786-stale-service-id
branch
from
November 16, 2026 12:26
4862faf to
180ad30
Compare
…identity Onboarding looked up the hypervisor/service pair only once, while the fields were empty, and adopted any record matching the hostname, including the leftover of a dead agent. After a node replacement the stored service ID can therefore point at an orphan: the enable step runs against the wrong service and the smoke test loops on 'No valid host' until someone clears status.serviceId by hand. Onboarding now adopts only a record whose service is up, and waits for one to register otherwise. When the stored service vanishes (the enable step returns 404) or the smoke test cannot be scheduled, the stored identity is cleared and the next resolve starts over with the current service. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
fwiesel
force-pushed
the
fix-786-stale-service-id
branch
from
November 16, 2026 12:59
180ad30 to
92d1527
Compare
Merging this branch will increase overall coverage
Coverage detailsCompared to commit cfee313 (run #43438290245)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
fwiesel
marked this pull request as ready for review
November 16, 2026 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a node replacement, onboarding can adopt the leftover compute record of the dead agent and store its service ID. When the replacement agent registers, the stored ID points at an orphan: the enable step runs against the wrong service, the current service stays disabled, and the smoke test loops on
No valid hostuntil someone clearsstatus.serviceIdand enables the service by hand.Onboarding now adopts only a record whose service is up, and waits for one to register otherwise. When the stored service vanishes (the enable step returns 404) or the smoke test cannot be scheduled, the stored identity is cleared and the next resolve starts over with the current service. Nova is not polled otherwise.